consti/dmc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop "Details:" label from the mission stats pill to save footer space

Browse Source 
The icons (flag/ruler/clock) already convey what each value means, so
the label was redundant. Gave the pill a stable Key since tests relied
on the now-removed text to find and tap it.
This commit is contained in:
Constantin Leue
2026-08-07 21:20:16 +02:00
parent 853cce5b26
commit ffad444e50
2 changed files with 12 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/lib/ui/widgets/bottom_stats_bar.dart
+5 -9
View File
@@ -249,6 +249,11 @@ class BottomStatsBar extends ConsumerWidget {
: _fmtDuration(totalDurationSec); : _fmtDuration(totalDurationSec);
return GestureDetector( return GestureDetector(
// Testhaken (siehe widget_test.dart): seit dem Entfernen des
// "Details:"-Labels (Nutzerwunsch: Platz sparen in Plan- und
// Fly-Modus) gibt es keinen eindeutigen Text mehr, um die Pille in
// Tests anzutippen.
key: const Key('detailsPill'),
onTap: onTap, onTap: onTap,
child: Container( child: Container(
height: _footerElementHeight, height: _footerElementHeight,
@@ -260,15 +265,6 @@ class BottomStatsBar extends ConsumerWidget {
child: Row( child: Row(
mainAxisSize: MainAxisSize.min, mainAxisSize: MainAxisSize.min,
children: [ children: [
const Text(
'Details:',
style: TextStyle(
color: Colors.white70,
fontWeight: _footerFontWeight,
fontSize: _footerFontSize,
),
),
const SizedBox(width: 10),
const Icon(Icons.flag, size: _footerIconSize, color: Colors.white), const Icon(Icons.flag, size: _footerIconSize, color: Colors.white),
const SizedBox(width: 4), const SizedBox(width: 4),
Text(waypointText, Text(waypointText,
app/test/widget_test.dart
+7 -7
View File
@@ -359,7 +359,7 @@ void main() {
(tester) async { (tester) async {
await _pumpWithContainer(tester); await _pumpWithContainer(tester);
await tester.tap(find.text('Details:')); await tester.tap(find.byKey(const Key('detailsPill')));
// Die Liste wird als eigene Route mit Fade-Transition gepusht: erst ein // Die Liste wird als eigene Route mit Fade-Transition gepusht: erst ein
// Frame ohne Dauer, damit der synchron ausgeloeste Navigator.push() // Frame ohne Dauer, damit der synchron ausgeloeste Navigator.push()
// registriert wird, danach die Animationszeit abwarten. // registriert wird, danach die Animationszeit abwarten.
@@ -377,7 +377,7 @@ void main() {
await tester.tap(find.byType(ReticleButton)); await tester.tap(find.byType(ReticleButton));
await tester.pump(); await tester.pump();
await tester.tap(find.text('Details:')); await tester.tap(find.byKey(const Key('detailsPill')));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(milliseconds: 200)); await tester.pump(const Duration(milliseconds: 200));
expect(find.byType(WaypointListPanel), findsOneWidget); expect(find.byType(WaypointListPanel), findsOneWidget);
@@ -400,7 +400,7 @@ void main() {
await tester.tap(find.byType(ReticleButton)); await tester.tap(find.byType(ReticleButton));
await tester.pump(); await tester.pump();
await tester.tap(find.text('Details:')); await tester.tap(find.byKey(const Key('detailsPill')));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(milliseconds: 200)); await tester.pump(const Duration(milliseconds: 200));
@@ -424,7 +424,7 @@ void main() {
await tester.tap(find.byType(ReticleButton)); await tester.tap(find.byType(ReticleButton));
await tester.pump(); await tester.pump();
await tester.tap(find.text('Details:')); await tester.tap(find.byKey(const Key('detailsPill')));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(milliseconds: 200)); await tester.pump(const Duration(milliseconds: 200));
@@ -457,7 +457,7 @@ void main() {
await tester.tap(find.byType(ReticleButton)); await tester.tap(find.byType(ReticleButton));
await tester.pump(); await tester.pump();
await tester.tap(find.text('Details:')); await tester.tap(find.byKey(const Key('detailsPill')));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(milliseconds: 200)); await tester.pump(const Duration(milliseconds: 200));
@@ -492,7 +492,7 @@ void main() {
await tester.tap(find.byType(ReticleButton)); await tester.tap(find.byType(ReticleButton));
await tester.pump(); await tester.pump();
await tester.tap(find.text('Details:')); await tester.tap(find.byKey(const Key('detailsPill')));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(milliseconds: 200)); await tester.pump(const Duration(milliseconds: 200));
@@ -519,7 +519,7 @@ void main() {
await tester.tap(find.byType(ReticleButton)); await tester.tap(find.byType(ReticleButton));
await tester.pump(); await tester.pump();
await tester.tap(find.text('Details:')); await tester.tap(find.byKey(const Key('detailsPill')));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(milliseconds: 200)); await tester.pump(const Duration(milliseconds: 200));