consti/dmc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename the Fly-mode Warnings tab to System Messages, log connection/upload events

Browse Source 
Renames DroneEvent/DroneEventSeverity/droneEventLogProvider/
DroneStatusWarningsPanel to SystemMessage/SystemMessageSeverity/
systemMessageLogProvider/DroneStatusMessagesPanel throughout, matching
what the tab now actually shows - general system messages, not just
drone-health warnings.

Adds a new SystemMessageSeverity.info level (blue) for messages that
aren't a warning/error, and three new message sources on top of the
existing battery/failsafe detection:
- "Connected", logged the first time telemetryProvider produces a frame
  after having none - the mirror image of the existing "Connection lost"
  detection (which already fires on the first stream error after having
  had data), so no new transport-specific dependency was needed.
- "Connection type changed to X", from watching connectionSettingsProvider
  (skips the initial load so it doesn't fire on every app start).
- "Mission sent (N waypoints)" / "Mission upload failed: ...", logged
  from FlyScreen's send handler via a new public log() method on the
  notifier, alongside the existing snackbar.

Verified on the Pixel_10a emulator: entering Fly mode logs "Connected"
once the mock telemetry starts, and tapping the send button logs
"Mission sent (3 waypoints)" right after the snackbar.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Constantin Leue
2026-08-06 10:47:38 +02:00
co-authored by Claude Sonnet 5
parent 13475cc4f3
commit b09d00ab9f
10 changed files with 386 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/test/domain/drone_event_test.dart → app/test/domain/system_message_test.dart
+14 -14
View File
@@ -1,6 +1,6 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:dmc_app/domain/telemetry/drone_event.dart';
import 'package:dmc_app/domain/telemetry/system_message.dart';
import 'package:dmc_app/transport/flight_controller_link.dart';
TelemetryFrame _frame({int batteryPercent = 80, int navMode = 0}) {
@@ -27,9 +27,9 @@ TelemetryFrame _frame({int batteryPercent = 80, int navMode = 0}) {
void main() {
final now = DateTime(2026, 1, 1, 12, 0, 0);
group('detectDroneEvents - battery', () {
group('detectSystemMessages - battery', () {
test('kein Ereignis ohne vorherigen Frame', () {
final events = detectDroneEvents(
final events = detectSystemMessages(
previous: null,
current: _frame(batteryPercent: 15),
now: now,
@@ -38,7 +38,7 @@ void main() {
});
test('kein Ereignis, solange keine Schwelle unterschritten wird', () {
final events = detectDroneEvents(
final events = detectSystemMessages(
previous: _frame(batteryPercent: 80),
current: _frame(batteryPercent: 75),
now: now,
@@ -47,29 +47,29 @@ void main() {
});
test('"Battery low" beim Unterschreiten von 30%', () {
final events = detectDroneEvents(
final events = detectSystemMessages(
previous: _frame(batteryPercent: 32),
current: _frame(batteryPercent: 28),
now: now,
);
expect(events, hasLength(1));
expect(events.single.severity, DroneEventSeverity.warning);
expect(events.single.severity, SystemMessageSeverity.warning);
expect(events.single.message, contains('Battery low'));
});
test('"Battery critical" beim Unterschreiten von 20%', () {
final events = detectDroneEvents(
final events = detectSystemMessages(
previous: _frame(batteryPercent: 22),
current: _frame(batteryPercent: 18),
now: now,
);
expect(events, hasLength(1));
expect(events.single.severity, DroneEventSeverity.critical);
expect(events.single.severity, SystemMessageSeverity.critical);
expect(events.single.message, contains('Battery critical'));
});
test('nur "Battery critical", wenn beide Schwellen im selben Schritt fallen', () {
final events = detectDroneEvents(
final events = detectSystemMessages(
previous: _frame(batteryPercent: 35),
current: _frame(batteryPercent: 15),
now: now,
@@ -79,7 +79,7 @@ void main() {
});
test('kein erneutes Ereignis, solange der Ladestand unter der Schwelle bleibt', () {
final events = detectDroneEvents(
final events = detectSystemMessages(
previous: _frame(batteryPercent: 25),
current: _frame(batteryPercent: 22),
now: now,
@@ -88,20 +88,20 @@ void main() {
});
});
group('detectDroneEvents - failsafe', () {
group('detectSystemMessages - failsafe', () {
test('"Failsafe mode activated" beim Wechsel in Emergency (navMode 15)', () {
final events = detectDroneEvents(
final events = detectSystemMessages(
previous: _frame(navMode: 3),
current: _frame(navMode: 15),
now: now,
);
expect(events, hasLength(1));
expect(events.single.severity, DroneEventSeverity.critical);
expect(events.single.severity, SystemMessageSeverity.critical);
expect(events.single.message, 'Failsafe mode activated');
});
test('kein erneutes Ereignis, solange Emergency anhaelt', () {
final events = detectDroneEvents(
final events = detectSystemMessages(
previous: _frame(navMode: 15),
current: _frame(navMode: 15),
now: now,
app/test/ui/providers/system_message_log_provider_test.dart
+142
View File
@@ -0,0 +1,142 @@
import 'dart:async';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:dmc_app/domain/telemetry/system_message.dart';
import 'package:dmc_app/transport/connection_type.dart';
import 'package:dmc_app/transport/flight_controller_link.dart';
import 'package:dmc_app/ui/providers/connection_settings_provider.dart';
import 'package:dmc_app/ui/providers/system_message_log_provider.dart';
import 'package:dmc_app/ui/providers/telemetry_provider.dart';
TelemetryFrame _frame() => const TelemetryFrame(
lat: 52.5,
lon: 13.4,
hasFix: true,
numSat: 10,
altitudeM: 100,
speedMs: 15,
headingDeg: 0,
armed: false,
batteryPercent: 80,
batteryVoltage: 22.0,
currentA: 10.0,
linkQuality: 90,
snrDb: 5,
hdop: 1.0,
navMode: 0,
flightMode: 'Idle',
);
typedef _ConnectionSettings = ({
int? activeDroneProfileId,
int? currentMissionId,
String? connectionDeviceAddress,
bool connectionAutoConnect,
ConnectionType connectionType,
String? connectionWifiHost,
int connectionWifiPort,
String connectionWifiSsidPrefix,
String? connectionWifiLastSsid,
});
_ConnectionSettings _settings(ConnectionType type) => (
activeDroneProfileId: null,
currentMissionId: null,
connectionDeviceAddress: null,
connectionAutoConnect: true,
connectionType: type,
connectionWifiHost: null,
connectionWifiPort: 14550,
connectionWifiSsidPrefix: 'mLRS-',
connectionWifiLastSsid: null,
);
void main() {
test('loggt "Connected" beim ersten Telemetrie-Frame und "Connection '
'lost" bei einem anschliessenden Stream-Fehler', () async {
final controller = StreamController<TelemetryFrame>();
addTearDown(controller.close);
final container = ProviderContainer(overrides: [
telemetryProvider.overrideWith((ref) => controller.stream),
connectionSettingsProvider
.overrideWith((ref) async => _settings(ConnectionType.mock)),
]);
addTearDown(container.dispose);
container.listen(systemMessageLogProvider, (previous, next) {});
controller.add(_frame());
await Future<void>.delayed(Duration.zero);
final afterConnect = container.read(systemMessageLogProvider);
expect(afterConnect, hasLength(1));
expect(afterConnect.single.message, 'Connected');
expect(afterConnect.single.severity, SystemMessageSeverity.info);
controller.addError(StateError('link down'));
await Future<void>.delayed(Duration.zero);
final afterLost = container.read(systemMessageLogProvider);
expect(afterLost.first.message, 'Connection lost');
expect(afterLost.first.severity, SystemMessageSeverity.critical);
});
test('loggt keine "Connected"-Meldung, solange nie ein Frame ankommt', () async {
final container = ProviderContainer(overrides: [
telemetryProvider.overrideWith((ref) => const Stream<TelemetryFrame>.empty()),
connectionSettingsProvider
.overrideWith((ref) async => _settings(ConnectionType.mock)),
]);
addTearDown(container.dispose);
container.listen(systemMessageLogProvider, (previous, next) {});
await Future<void>.delayed(Duration.zero);
expect(container.read(systemMessageLogProvider), isEmpty);
});
test('loggt "Connection type changed" bei einer Aenderung, nicht beim '
'initialen Laden der Einstellungen', () async {
var type = ConnectionType.wifi;
final container = ProviderContainer(overrides: [
telemetryProvider.overrideWith((ref) => const Stream<TelemetryFrame>.empty()),
connectionSettingsProvider.overrideWith((ref) async => _settings(type)),
]);
addTearDown(container.dispose);
container.listen(systemMessageLogProvider, (previous, next) {});
await container.read(connectionSettingsProvider.future);
expect(container.read(systemMessageLogProvider), isEmpty);
type = ConnectionType.mock;
container.invalidate(connectionSettingsProvider);
await container.read(connectionSettingsProvider.future);
final log = container.read(systemMessageLogProvider);
expect(log.single.message, 'Connection type changed to Mock (Test)');
expect(log.single.severity, SystemMessageSeverity.info);
});
test('log() fuegt einen Eintrag manuell hinzu (Doku: Wegpunkte uebertragen)', () async {
final container = ProviderContainer(overrides: [
telemetryProvider.overrideWith((ref) => const Stream<TelemetryFrame>.empty()),
connectionSettingsProvider
.overrideWith((ref) async => _settings(ConnectionType.mock)),
]);
addTearDown(container.dispose);
container.read(systemMessageLogProvider.notifier).log('Mission sent (3 waypoints)');
var log = container.read(systemMessageLogProvider);
expect(log.single.message, 'Mission sent (3 waypoints)');
expect(log.single.severity, SystemMessageSeverity.info);
container.read(systemMessageLogProvider.notifier).log(
'Mission upload failed: timeout',
severity: SystemMessageSeverity.critical,
);
log = container.read(systemMessageLogProvider);
expect(log.first.message, 'Mission upload failed: timeout');
expect(log.first.severity, SystemMessageSeverity.critical);
});
}
app/test/widget_test.dart
+38
View File
@@ -33,6 +33,7 @@ import 'package:dmc_app/ui/widgets/header_wind_pill.dart';
import 'package:dmc_app/ui/widgets/map_search_controls.dart';
import 'package:dmc_app/ui/providers/map_controller_provider.dart';
import 'package:dmc_app/ui/widgets/missions_drones_panel.dart';
import 'package:dmc_app/ui/widgets/paper_plane_icon.dart';
import 'package:dmc_app/ui/widgets/reticle_button.dart';
import 'package:dmc_app/ui/widgets/waypoint_chip.dart';
import 'package:dmc_app/ui/widgets/waypoint_list_panel.dart';
@@ -1001,6 +1002,43 @@ void main() {
await _stopTelemetry(container);
});
testWidgets(
'Drohnen-Status-Pille oeffnet "Drone Status & System Messages", '
'System-Messages-Tab zeigt "Connected" nach der ersten Telemetrie',
(tester) async {
final container = _testContainer();
addTearDown(container.dispose);
await tester.pumpWidget(
UncontrolledProviderScope(
container: container,
child: BlocProvider(
create: (_) => AppModeCubit(),
child: const MaterialApp(home: AppShell()),
),
),
);
await tester.pump();
await tester.tap(find.text('Fly'));
await tester.pump();
// MockFlightControllerLink tickt erst nach 1s (siehe oben).
await tester.pump(const Duration(seconds: 1, milliseconds: 100));
// Zwei PaperPlaneIcon-Instanzen im Fly-Fusszeile (Drohnen-Status-Pille
// UND der pinke Sende-Knopf, siehe bottom_stats_bar.dart) - die Pille
// steht im Widget-Baum zuerst.
await tester.tap(find.byType(PaperPlaneIcon).first);
await tester.pumpAndSettle();
expect(find.text('Drone Status & System Messages'), findsOneWidget);
await tester.tap(find.text('System Messages'));
await tester.pumpAndSettle();
expect(find.text('Connected'), findsOneWidget);
await _stopTelemetry(container);
});
testWidgets('Fit-Button im Fly-Modus ohne Wegpunkte zeigt Hinweis statt Absturz',
(tester) async {
final container = _testContainer();